Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency between TrainDataset and EvalDataset's code #128

Open
jsalzRR opened this issue Feb 7, 2022 · 0 comments
Open

Inconsistency between TrainDataset and EvalDataset's code #128

jsalzRR opened this issue Feb 7, 2022 · 0 comments

Comments

@jsalzRR
Copy link

jsalzRR commented Feb 7, 2022

Hi, I happened to stumble upon this :
In TrainDataset.get_render :

            # Match camera space to image pixel space
            scale_intrinsic = np.identity(4)
            scale_intrinsic[0, 0] = scale / ortho_ratio
            scale_intrinsic[1, 1] = -scale / ortho_ratio
            scale_intrinsic[2, 2] = scale / ortho_ratio

In EvalDataset.get_render :

            # Match camera space to image pixel space
            scale_intrinsic = np.identity(4)
            scale_intrinsic[0, 0] = scale / ortho_ratio
            scale_intrinsic[1, 1] = -scale / ortho_ratio
            scale_intrinsic[2, 2] = -scale / ortho_ratio

Is the fact that there is an additional minus sign in EvalDataset wanted ? If it is, I would be grateful if you could explain why these implementations are different :)

Good day !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant