Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Velero has to be configured even when dr module is not installed #207

Open
FedericoAntoniazzi opened this issue Apr 11, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@FedericoAntoniazzi
Copy link
Member

Hello there,

I see the schema validation fails when spec.distribution.modules.dr.type is set to none because it still requires spec.distribution.modules.dr.velero to be set.

apiVersion: kfd.sighup.io/v1alpha2
kind: OnPremises
metadata:
  name: furydemo
spec:
  distributionVersion: v1.27.3
  ...
  distribution:
    modules:
      dr:
        type: none
      ...
furyctl validate config
INFO Downloading distribution...                  
INFO Compatibility patches applied for v1.27.3    
ERRO error while validating against schema: jsonschema: '/spec/distribution/modules/dr' does not validate with file:///var/folders/mf/vblq1rpx01571403sbmyb6m40000gn/T/furyctl-2325438801/data/schemas/public/onpremises-kfd-v1alpha2.json#/properties/spec/$ref/properties/distribution/$ref/properties/modules/$ref/properties/dr/$ref/required: missing properties: 'velero' 
ERRO configuration file validation failed

Additional info

furyctl version
buildTime: 2024-03-26T12:02:24Z
gitCommit: 334082c40678df83615e40a14376a540e6243a1c
goVersion: go1.22.0
osArch: amd64
version: 0.27.8
@FedericoAntoniazzi FedericoAntoniazzi added the bug Something isn't working label Apr 11, 2024
@nutellinoit
Copy link
Member

as a workaround you just need to add velero: {}

we should fix the schema rules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants