fixed translation registration for the validators

silexphp · Sep 15, 2015 · 4f560c9 · 4f560c9
1 parent c31743e
commit 4f560c9
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 25 deletions.
diff --git a/doc/changelog.rst b/doc/changelog.rst
@@ -4,7 +4,7 @@ Changelog
 1.3.4 (2015-XX-XX)
 ------------------
 
-* n/a
+* fixed translation registration for the validators
 
 1.3.3 (2015-09-08)
 ------------------

diff --git a/src/Silex/Provider/FormServiceProvider.php b/src/Silex/Provider/FormServiceProvider.php
@@ -78,14 +78,6 @@ public function register(Application $app)
 
             if (isset($app['validator'])) {
                 $extensions[] = new FormValidatorExtension($app['validator']);
-
-                if (isset($app['translator'])) {
-                    $r = new \ReflectionClass('Symfony\Component\Form\Form');
-                    $file = dirname($r->getFilename()).'/Resources/translations/validators.'.$app['locale'].'.xlf';
-                    if (file_exists($file)) {
-                        $app['translator']->addResource('xliff', $file, $app['locale'], 'validators');
-                    }
-                }
             }
 
             return $extensions;

diff --git a/src/Silex/Provider/TranslationServiceProvider.php b/src/Silex/Provider/TranslationServiceProvider.php
@@ -40,6 +40,22 @@ public function register(Application $app)
             $translator->addLoader('array', new ArrayLoader());
             $translator->addLoader('xliff', new XliffFileLoader());
 
+            if (isset($app['validator'])) {
+                $r = new \ReflectionClass('Symfony\Component\Validator\Validation');
+                $file = dirname($r->getFilename()).'/Resources/translations/validators.'.$app['locale'].'.xlf';
+                if (file_exists($file)) {
+                    $translator->addResource('xliff', $file, $app['locale'], 'validators');
+                }
+            }
+
+            if (isset($app['form.factory'])) {
+                $r = new \ReflectionClass('Symfony\Component\Form\Form');
+                $file = dirname($r->getFilename()).'/Resources/translations/validators.'.$app['locale'].'.xlf';
+                if (file_exists($file)) {
+                    $translator->addResource('xliff', $file, $app['locale'], 'validators');
+                }
+            }
+
             // Register default resources
             foreach ($app['translator.resources'] as $resource) {
                 $translator->addResource($resource[0], $resource[1], $resource[2], $resource[3]);

diff --git a/src/Silex/Provider/ValidatorServiceProvider.php b/src/Silex/Provider/ValidatorServiceProvider.php
@@ -29,20 +29,6 @@ class ValidatorServiceProvider implements ServiceProviderInterface
     public function register(Application $app)
     {
         $app['validator'] = $app->share(function ($app) {
-            if (isset($app['translator'])) {
-                $r = new \ReflectionClass('Symfony\Component\Validator\Validation');
-                $file = dirname($r->getFilename()).'/Resources/translations/validators.'.$app['locale'].'.xlf';
-                if (file_exists($file)) {
-                    $app->extend('translator.resources', function ($resources, $app) use ($file) {
-                        $resources = array_merge(array(
-                            array('xliff', $file, $app['locale'], 'validators'),
-                        ), $resources);
-
-                        return $resources;
-                    });
-                }
-            }
-
             return $app['validator.builder']->getValidator();
         });
 

diff --git a/tests/Silex/Tests/Provider/ValidatorServiceProviderTest.php b/tests/Silex/Tests/Provider/ValidatorServiceProviderTest.php
@@ -150,7 +150,10 @@ public function getTestValidatorConstraintProvider()
         );
     }
 
-    public function testAddResource()
+    /**
+     * @dataProvider getAddResourceData
+     */
+    public function testAddResource($registerValidatorFirst)
     {
         $app = new Application();
         $app['locale'] = 'fr';
@@ -163,11 +166,18 @@ public function testAddResource()
             return $translator;
         }));
 
-        $app['validator'];
+        if ($registerValidatorFirst) {
+            $app['validator'];
+        }
 
         $this->assertEquals('Pas vide', $app['translator']->trans('This value should not be blank.', array(), 'validators', 'fr'));
     }
 
+    public function getAddResourceData()
+    {
+        return array(array(false), array(true));
+    }
+
     public function testAddResourceAlternate()
     {
         $app = new Application();