Skip to content
This repository has been archived by the owner on Jul 4, 2018. It is now read-only.

Commit

Permalink
allowed Symfony 3.0
Browse files Browse the repository at this point in the history
  • Loading branch information
fabpot committed Sep 8, 2015
1 parent 436aded commit dc97b3a
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 27 deletions.
14 changes: 7 additions & 7 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@ cache:

before_script:
# symfony/*
- sh -c "if [ '$SYMFONY_DEPS_VERSION' = '2.8' ]; then sed -i 's/~2.3/2.8.*@dev/g' composer.json; composer update --dev --prefer-source; fi"
- sh -c "if [ '$SYMFONY_DEPS_VERSION' = '2.7' ]; then sed -i 's/~2.3/2.7.*@dev/g' composer.json; composer update --dev --prefer-source; fi"
- sh -c "if [ '$SYMFONY_DEPS_VERSION' = '' ]; then sed -i 's/~2.3/2.6.*@dev/g' composer.json; composer update --dev --prefer-source; fi"
- sh -c "if [ '$SYMFONY_DEPS_VERSION' = '2.3' ]; then sed -i 's/~2.3/2.3.*@dev/g' composer.json; composer update --dev --prefer-source; fi"
- composer install --dev --prefer-source
- sh -c "if [ '$SYMFONY_DEPS_VERSION' = '3.0' ]; then sed -i 's/~2\.3|3\.0\.\*/3.0.*@dev/g' composer.json; composer update; fi"
- sh -c "if [ '$SYMFONY_DEPS_VERSION' = '2.8' ]; then sed -i 's/~2\.3|3\.0\.\*/2.8.*@dev/g' composer.json; composer update; fi"
- sh -c "if [ '$SYMFONY_DEPS_VERSION' = '' ]; then sed -i 's/~2\.3|3\.0\.\*/2.7.*@dev/g' composer.json; composer update; fi"
- sh -c "if [ '$SYMFONY_DEPS_VERSION' = '2.3' ]; then sed -i 's/~2\.3|3\.0\.\*/2.3.*@dev/g' composer.json; composer update; fi"
- composer install

script: phpunit

Expand All @@ -23,9 +23,9 @@ matrix:
- php: 5.5
- php: 5.6
env: SYMFONY_DEPS_VERSION=2.3
- php: 5.6
env: SYMFONY_DEPS_VERSION=2.7
- php: 5.6
env: SYMFONY_DEPS_VERSION=2.8
- php: 5.6
env: SYMFONY_DEPS_VERSION=3
- php: 7.0
- php: hhvm
40 changes: 20 additions & 20 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,29 +17,29 @@
"require": {
"php": ">=5.3.9",
"pimple/pimple": "~1.0",
"symfony/event-dispatcher": "~2.3",
"symfony/http-foundation": "~2.3",
"symfony/http-kernel": "~2.3",
"symfony/routing": "~2.3"
"symfony/event-dispatcher": "~2.3|3.0.*",
"symfony/http-foundation": "~2.3|3.0.*",
"symfony/http-kernel": "~2.3|3.0.*",
"symfony/routing": "~2.3|3.0.*"
},
"require-dev": {
"symfony/security": "~2.3",
"symfony/config": "~2.3",
"symfony/locale": "~2.3",
"symfony/form": "~2.3",
"symfony/browser-kit": "~2.3",
"symfony/css-selector": "~2.3",
"symfony/debug": "~2.3",
"symfony/dom-crawler": "~2.3",
"symfony/finder": "~2.3",
"symfony/monolog-bridge": "~2.3",
"symfony/options-resolver": "~2.3",
"symfony/security": "~2.3|3.0.*",
"symfony/config": "~2.3|3.0.*",
"symfony/locale": "~2.3|3.0.*",
"symfony/form": "~2.3|3.0.*",
"symfony/browser-kit": "~2.3|3.0.*",
"symfony/css-selector": "~2.3|3.0.*",
"symfony/debug": "~2.3|3.0.*",
"symfony/dom-crawler": "~2.3|3.0.*",
"symfony/finder": "~2.3|3.0.*",
"symfony/monolog-bridge": "~2.3|3.0.*",
"symfony/options-resolver": "~2.3|3.0.*",
"symfony/phpunit-bridge": "~2.7",
"symfony/process": "~2.3",
"symfony/serializer": "~2.3",
"symfony/translation": "~2.3",
"symfony/twig-bridge": "~2.3",
"symfony/validator": "~2.3",
"symfony/process": "~2.3|3.0.*",
"symfony/serializer": "~2.3|3.0.*",
"symfony/translation": "~2.3|3.0.*",
"symfony/twig-bridge": "~2.3|3.0.*",
"symfony/validator": "~2.3|3.0.*",
"twig/twig": "~1.8",
"doctrine/dbal": "~2.2",
"swiftmailer/swiftmailer": "~5",
Expand Down

7 comments on commit dc97b3a

@theintz
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit breaks backward compatibility. Symfony 3.0 requires PHP >= 5.5.9, which means I can't use it with my hand-maintained version of PHP 5.5.8. Symfony 2.3 was fine with PHP >= 5.3.3. Please increase at least the minor version for fundamental changes like these.

@GromNaN
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theintz This commit does not remove the compatibility with older versions of Symfony.
On PHP 5.5.8, you can use Silex 1.3 with Symfony 2.8

You can see on this build all the PHP versions supported by Silex 1.3.
https://travis-ci.org/silexphp/Silex/builds/100596920

If you have a specific issue, please create an issue giving the list of your composer dependencies and a clear description of your problem.

@theintz
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats correct. But in order to pull in Symfony <3.0, I have to explicitly specify it in my project's composer.json, which forces me to know about Silex's dependencies.

@stof
Copy link
Contributor

@stof stof commented on dc97b3a Jan 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no. you can also simply configure your project to tell composer that it needs to select packages compatible with PHP 5.5.8 instead of using the PHP version from the runtime used to run composer: https://getcomposer.org/doc/06-config.md#platform (or just run composer update on a machine running PHP 5.5.8 too)

@theintz
Copy link

@theintz theintz commented on dc97b3a Feb 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or just run composer update on a machine running PHP 5.5.8

Thats exactly what I am doing. Still composer tries to install Symfony 3.0 and complains when it can't because of PHP being too old.

@stof
Copy link
Contributor

@stof stof commented on dc97b3a Feb 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theintz are you running composer install (from a lock file) or composer update ?

@theintz
Copy link

@theintz theintz commented on dc97b3a Feb 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im running composer update. My exact PHP version is 5.5.8-6.

Please sign in to comment.