This repository has been archived by the owner on Jul 4, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 719
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
2 changed files
with
27 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dc97b3a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit breaks backward compatibility. Symfony 3.0 requires PHP >= 5.5.9, which means I can't use it with my hand-maintained version of PHP 5.5.8. Symfony 2.3 was fine with PHP >= 5.3.3. Please increase at least the minor version for fundamental changes like these.
dc97b3a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@theintz This commit does not remove the compatibility with older versions of Symfony.
On PHP 5.5.8, you can use Silex 1.3 with Symfony 2.8
You can see on this build all the PHP versions supported by Silex 1.3.
https://travis-ci.org/silexphp/Silex/builds/100596920
If you have a specific issue, please create an issue giving the list of your composer dependencies and a clear description of your problem.
dc97b3a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats correct. But in order to pull in Symfony <3.0, I have to explicitly specify it in my project's composer.json, which forces me to know about Silex's dependencies.
dc97b3a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no. you can also simply configure your project to tell composer that it needs to select packages compatible with PHP 5.5.8 instead of using the PHP version from the runtime used to run composer: https://getcomposer.org/doc/06-config.md#platform (or just run
composer update
on a machine running PHP 5.5.8 too)dc97b3a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats exactly what I am doing. Still composer tries to install Symfony 3.0 and complains when it can't because of PHP being too old.
dc97b3a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@theintz are you running
composer install
(from a lock file) orcomposer update
?dc97b3a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im running
composer update
. My exact PHP version is 5.5.8-6.