Skip to content

Commit

Permalink
BUG Find Form actions in CompositeFields for access checks
Browse files Browse the repository at this point in the history
This bug was introduced with the new nested CMS actions
around December 2012, but wasn't noticed until now
because checkAccessAction() would wrongly return TRUE
before the dataFieldByName() check was reached.
  • Loading branch information
chillu committed Feb 18, 2013
1 parent 7ec8ebb commit 14dcc82
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion forms/Form.php
Expand Up @@ -289,7 +289,7 @@ public function httpSubmission($request) {
$this->controller->hasMethod($funcName)
&& !$this->controller->checkAccessAction($funcName)
// If a button exists, allow it on the controller
&& !$this->actions->fieldByName('action_' . $funcName)
&& !$this->actions->dataFieldByName('action_' . $funcName)
) {
return $this->httpError(
403,
Expand Down

0 comments on commit 14dcc82

Please sign in to comment.