Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to return a warning instead of error when checks fail #94

Open
sabina-talipova opened this issue Oct 11, 2023 · 0 comments
Open

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Oct 11, 2023

Description

CacheHeadersCheck::check() method checks that correct caching headers are present. Method should return EnvironmentCheck::WARNING if validation result messageType is ValidationResult::TYPE_WARNING. Necessary to add additional check for message type.

See:

// @todo Ability to return a warning
return [
EnvironmentCheck::ERROR,
$this->getMessage(),
];

@GuySartorelli GuySartorelli changed the title TODO: CacheHeadersCheck::check(). Add ability to return a warning Add ability to return a warning instead of error when checks fail Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant