Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move asgiref to test dependencies #2272

Open
simonw opened this issue Feb 14, 2024 · 0 comments
Open

Move asgiref to test dependencies #2272

simonw opened this issue Feb 14, 2024 · 0 comments
Labels
refactor tests

Comments

@simonw
Copy link
Owner

simonw commented Feb 14, 2024

It's in regular dependencies here:

datasette/setup.py

Lines 44 to 45 in b89cac3

install_requires=[
"asgiref>=3.2.10",

But it's only used here:

datasette/datasette/utils/testing.py

Line 1 in b89cac3

from asgiref.sync import async_to_sync

I should move datasette/utils/testing.py into test/ too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw