Delete unused Thumbnail handling code

The-Powder-Toy · Nov 28, 2018 · 87fb94c · 87fb94c
1 parent d0dd9ec
commit 87fb94c
Show file tree

Hide file tree

Showing 16 changed files with 12 additions and 174 deletions.
diff --git a/src/Config.h b/src/Config.h
@@ -101,9 +101,6 @@
 #define M_GRAV 6.67300e-1
 #endif
 
-//Number of asynchronous connections used to retrieve thumbnails
-#define IMGCONNS 5
-
 #ifdef RENDERER
 #define MENUSIZE 0
 #define BARSIZE 0

diff --git a/src/client/Client.cpp b/src/client/Client.cpp
@@ -42,7 +42,6 @@
 #include "client/SaveFile.h"
 #include "client/GameSave.h"
 #include "client/UserInfo.h"
-#include "gui/search/Thumbnail.h"
 #include "gui/preview/Comment.h"
 #include "ClientListener.h"
 #include "requestbroker/RequestBroker.h"
@@ -70,18 +69,6 @@ Client::Client():
 	updateAvailable(false),
 	authUser(0, "")
 {
-	int i = 0;
-	for(i = 0; i < THUMB_CACHE_SIZE; i++)
-	{
-		thumbnailCache[i] = NULL;
-	}
-	for(i = 0; i < IMGCONNS; i++)
-	{
-		activeThumbRequests[i] = NULL;
-		activeThumbRequestTimes[i] = 0;
-		activeThumbRequestCompleteTimes[i] = 0;
-	}
-
 	//Read config
 	std::ifstream configFile;
 	configFile.open("powder.pref", std::ios::binary);
@@ -952,7 +939,6 @@ void Client::WritePrefs()
 void Client::Shutdown()
 {
 	RequestBroker::Ref().Shutdown();
-	ClearThumbnailRequests();
 	http_done();
 
 	//Save config
@@ -1874,20 +1860,6 @@ std::vector<SaveInfo*> * Client::SearchSaves(int start, int count, String query,
 	return saveArray;
 }
 
-void Client::ClearThumbnailRequests()
-{
-	for(int i = 0; i < IMGCONNS; i++)
-	{
-		if(activeThumbRequests[i])
-		{
-			http_async_req_close(activeThumbRequests[i]);
-			activeThumbRequests[i] = NULL;
-			activeThumbRequestTimes[i] = 0;
-			activeThumbRequestCompleteTimes[i] = 0;
-		}
-	}
-}
-
 std::list<ByteString> * Client::RemoveTag(int saveID, ByteString tag)
 {
 	lastError = "";

diff --git a/src/client/Client.h b/src/client/Client.h
@@ -16,7 +16,6 @@
 
 #include "requestbroker/RequestBroker.h"
 
-class Thumbnail;
 class SaveInfo;
 class SaveFile;
 class SaveComment;
@@ -70,13 +69,6 @@ class Client: public Singleton<Client> {
 	//Auth session
 	User authUser;
 
-	//Thumbnail retreival
-	int thumbnailCacheNextID;
-	Thumbnail * thumbnailCache[THUMB_CACHE_SIZE];
-	void * activeThumbRequests[IMGCONNS];
-	int activeThumbRequestTimes[IMGCONNS];
-	int activeThumbRequestCompleteTimes[IMGCONNS];
-	ByteString activeThumbRequestIDs[IMGCONNS];
 	void notifyUpdateAvailable();
 	void notifyAuthUserChanged();
 	void notifyMessageOfTheDay();
@@ -160,7 +152,6 @@ class Client: public Singleton<Client> {
 	std::vector<unsigned char> GetSaveData(int saveID, int saveDate);
 
 	LoginStatus Login(ByteString username, ByteString password, User & user);
-	void ClearThumbnailRequests();
 	std::vector<SaveInfo*> * SearchSaves(int start, int count, String query, ByteString sort, ByteString category, int & resultCount);
 	std::vector<std::pair<ByteString, int> > * GetTags(int start, int count, String query, int & resultCount);
 

diff --git a/src/client/SaveFile.cpp b/src/client/SaveFile.cpp
@@ -1,33 +1,18 @@
 #include "SaveFile.h"
 #include "GameSave.h"
 #include "Client.h"
-#include "gui/search/Thumbnail.h"
 
 SaveFile::SaveFile(SaveFile & save):
-	thumbnail(NULL),
 	gameSave(NULL),
 	filename(save.filename),
 	displayName(save.displayName),
 	loadingError(save.loadingError)
 {
 	if (save.gameSave)
 		gameSave = new GameSave(*save.gameSave);
-	if (save.thumbnail)
-		thumbnail = new Thumbnail(*save.thumbnail);
-}
-
-Thumbnail * SaveFile::GetThumbnail()
-{
-	return thumbnail;
-}
-
-void SaveFile::SetThumbnail(Thumbnail * thumb)
-{
-	thumbnail = thumb;
 }
 
 SaveFile::SaveFile(ByteString filename):
-	thumbnail(NULL),
 	gameSave(NULL),
 	filename(filename),
 	displayName(filename.FromUtf8()),
@@ -78,6 +63,5 @@ void SaveFile::SetLoadingError(String error)
 
 SaveFile::~SaveFile() {
 	delete gameSave;
-	delete thumbnail;
 }
 
diff --git a/src/client/SaveFile.h b/src/client/SaveFile.h
@@ -4,16 +4,13 @@
 #include "common/String.h"
 
 class GameSave;
-class Thumbnail;
 
 class SaveFile {
 public:
 	SaveFile(SaveFile & save);
 	SaveFile(ByteString filename);
 
-	Thumbnail * GetThumbnail();
 	GameSave * GetGameSave();
-	void SetThumbnail(Thumbnail * thumb);
 	void SetGameSave(GameSave * save);
 	String GetDisplayName();
 	void SetDisplayName(String displayName);
@@ -24,7 +21,6 @@ class SaveFile {
 
 	virtual ~SaveFile();
 private:
-	Thumbnail * thumbnail;
 	GameSave * gameSave;
 	ByteString filename;
 	String displayName;

diff --git a/src/gui/filebrowser/FileBrowserActivity.cpp b/src/gui/filebrowser/FileBrowserActivity.cpp
@@ -16,9 +16,6 @@
 #include "gui/dialogues/ConfirmPrompt.h"
 #include "gui/dialogues/ErrorMessage.h"
 
-class Thumbnail;
-
-
 class SaveSelectedAction: public ui::SaveButtonAction
 {
 	FileBrowserActivity * a;

diff --git a/src/gui/game/GameView.cpp b/src/gui/game/GameView.cpp
@@ -19,7 +19,6 @@
 #include "gui/interface/Mouse.h"
 #include "gui/interface/Slider.h"
 #include "gui/interface/Window.h"
-#include "gui/search/Thumbnail.h"
 #include "simulation/SaveRenderer.h"
 #include "simulation/SimulationData.h"
 

diff --git a/src/gui/preview/PreviewModel.h b/src/gui/preview/PreviewModel.h
@@ -6,7 +6,6 @@
 #include "PreviewView.h"
 #include "client/SaveInfo.h"
 #include "gui/preview/Comment.h"
-#include "gui/search/Thumbnail.h"
 #include "client/Download.h"
 
 using namespace std;

diff --git a/src/gui/preview/PreviewView.cpp b/src/gui/preview/PreviewView.cpp
@@ -9,7 +9,6 @@
 #include "gui/interface/Textbox.h"
 #include "gui/Style.h"
 #include "Format.h"
-#include "gui/search/Thumbnail.h"
 #include "gui/profile/ProfileActivity.h"
 #include "client/Client.h"
 #include "gui/interface/ScrollPanel.h"

diff --git a/src/gui/save/LocalSaveActivity.cpp b/src/gui/save/LocalSaveActivity.cpp
@@ -1,15 +1,18 @@
 #include "LocalSaveActivity.h"
-#include "gui/interface/Label.h"
-#include "gui/interface/Textbox.h"
-#include "gui/interface/Button.h"
-#include "gui/search/Thumbnail.h"
-#include "client/requestbroker/RequestBroker.h"
-#include "gui/dialogues/ErrorMessage.h"
-#include "gui/dialogues/ConfirmPrompt.h"
+#include "images.h"
+
 #include "client/Client.h"
 #include "client/GameSave.h"
+#include "graphics/Graphics.h"
 #include "gui/Style.h"
-#include "images.h"
+
+#include "client/requestbroker/RequestBroker.h"
+#include "gui/dialogues/ConfirmPrompt.h"
+#include "gui/dialogues/ErrorMessage.h"
+#include "gui/interface/Button.h"
+#include "gui/interface/Label.h"
+#include "gui/interface/Textbox.h"
+
 
 class LocalSaveActivity::CancelAction: public ui::ButtonAction
 {

diff --git a/src/gui/save/ServerSaveActivity.h b/src/gui/save/ServerSaveActivity.h
@@ -13,7 +13,6 @@ namespace ui
 }
 
 class Task;
-class Thumbnail;
 class VideoBuffer;
 class ServerSaveActivity: public WindowActivity, public RequestListener, public TaskListener
 {

diff --git a/src/gui/search/SearchController.cpp b/src/gui/search/SearchController.cpp
@@ -2,6 +2,7 @@
 #include "SearchController.h"
 #include "SearchModel.h"
 #include "SearchView.h"
+#include "graphics/Graphics.h"
 #include "gui/interface/Panel.h"
 #include "gui/dialogues/ConfirmPrompt.h"
 #include "gui/dialogues/ErrorMessage.h"

diff --git a/src/gui/search/SearchView.cpp b/src/gui/search/SearchView.cpp
@@ -582,7 +582,6 @@ void SearchView::NotifySaveListChanged(SearchModel * sender)
 	else
 		favouriteSelected->SetText("Favourite");
 
-	Client::Ref().ClearThumbnailRequests();
 	for (size_t i = 0; i < saveButtons.size(); i++)
 	{
 		RemoveComponent(saveButtons[i]);

diff --git a/src/gui/search/Thumbnail.cpp b/src/gui/search/Thumbnail.cpp
diff --git a/src/gui/search/Thumbnail.h b/src/gui/search/Thumbnail.h
diff --git a/src/simulation/SaveRenderer.cpp b/src/simulation/SaveRenderer.cpp
@@ -3,7 +3,6 @@
 #include "graphics/Graphics.h"
 #include "Simulation.h"
 #include "graphics/Renderer.h"
-#include "gui/search/Thumbnail.h"
 
 
 SaveRenderer::SaveRenderer(){