params can't be used as keyword arguments

[baelter]

We can't pass params hash and expect keyword args to be matched because of the current IndifferentHash implementation.

def a(a:, **); end
a(Hash[a: 1]) # => nil
a(Sinatra::IndifferentHash[a: 1]) # => ArgumentError (wrong number of arguments (given 1, expected 0; required keyword: a))
a(**Sinatra::IndifferentHash[a: 1]) # => TypeError (hash key "a" is not a Symbol)

Changing the IndifferentHash private method convert_key to always return key.to_s.to_sym solves this.

[jkowens]

This issue has also been brought up in the Rails project. Since this models ActiveSupport::HashWithIndifferentAccess I would like to stay in line with the approach there. I'm wondering if we can also provide a method symbolize_keys that will serve as a work around.

See:

rails/rails#14643

https://bugs.ruby-lang.org/issues/9731

https://til.hashrocket.com/posts/d66e55091c-hashwithindifferentaccess-for-keyword-arguments

[baelter]

Okey, maybe it can be done as an opt-in setting. I'll look into that.