Schema is wrong within Orders

[nickdegiacomo]

Within Orders, there are several fields that are not filled out
https://github.com/singer-io/tap-shopify/blob/master/tap_shopify/schemas/orders.json#L9-L14

"subtotal_price_set": {},
"total_discounts_set": {},
"total_line_items_price_set": {},
"total_price_set": {},
"total_shipping_price_set": {},
"total_tax_set": {},

There may be more, but these are most obvious.

[nigelvining]

I just stumbled across this as well .. are these schemas all hand crafted ? I can't find a shopify endpoint that specifically returns a schema for each payload type to allow them to be auto generated .... if anyone knows of one, i would be most grateful. To get it working ....

I added the following to definitions.json

"_price_set": { "type": [ "null", "object" ], "properties": { "shop_money": { "type": [ "null", "object" ], "properties": { "currency_code": { "type": ["null","string"] }, "amount": { "type": ["null","string"], "format": "singer.decimal" } } }, "presentment_money": { "type": [ "null", "object" ], "properties": { "currency_code": { "type": ["null","string"] }, "amount": { "type": ["null","string"], "format": "singer.decimal" } } } } },

...... then updated orders.json

"subtotal_price_set": { "$ref": "definitions.json#/_price_set" }, "total_discounts_set": { "$ref": "definitions.json#/_price_set" }, etc etc