Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[c++] Add missing parameters for SOMACollection::add_new_{soma_object} #2509

Open
nguyenv opened this issue May 6, 2024 · 1 comment · May be fixed by #2508
Open

[c++] Add missing parameters for SOMACollection::add_new_{soma_object} #2509

nguyenv opened this issue May 6, 2024 · 1 comment · May be fixed by #2508
Assignees
@nguyenv
Labels
cpp-api

Comments

@nguyenv
Copy link
Member

nguyenv commented May 6, 2024

  • All setters require timestamp argument
  • Any setter that adds a SOMAArray also needs a parameter for the result_order and platform_config
@nguyenv nguyenv self-assigned this May 6, 2024
@nguyenv nguyenv added the cpp-api label May 6, 2024
@nguyenv nguyenv linked a pull request May 6, 2024 that will close this issue
Open
@johnkerl
Copy link
Member

johnkerl commented May 6, 2024

Single-PR task

@nguyenv nguyenv linked a pull request May 7, 2024 that will close this issue
[c++] Add missing SOMACollection getters and setters #2508
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nguyenv nguyenv

Labels
cpp-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[c++] Add missing SOMACollection getters and setters single-cell-data/TileDB-SOMA
2 participants
@johnkerl @nguyenv