Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add log limit to assert.fake #2560

Closed
wants to merge 6 commits into from
Closed

Add log limit to assert.fake #2560

wants to merge 6 commits into from

Conversation

fatso83
Copy link
Contributor

@fatso83 fatso83 commented Oct 25, 2023 •
edited

Purpose (TL;DR) - mandatory

This basically re-implements #2485 (which fixes #2484), addressing the concerns raised there, adding tests and fixes a few other nuisances while at it.

How to verify - mandatory

  1. Check out this branch
  2. npm install
  3. npm test

Checklist for author

  • npm run lint passes
  • References to standard library functions are cached.

@fatso83 fatso83 changed the title Cleanup unimported setup & include test files Add log limit to assert.fake Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8dbfd02) 96.03% compared to head (699b104) 96.06%.
Report is 3 commits behind head on main.

❗ Current head 699b104 differs from pull request most recent head 3cc346c. Consider uploading reports for the commit 3cc346c to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2560      +/-   ##
==========================================
+ Coverage   96.03%   96.06%   +0.03%     
==========================================
  Files          40       41       +1     
  Lines        1915     1933      +18     
==========================================
+ Hits         1839     1857      +18     
  Misses         76       76
Flag Coverage Δ
unit 96.06% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
lib/create-sinon-api.js 100.00% <100.00%> (ø)
lib/sinon.js 100.00% <100.00%> (ø)
lib/sinon/assert.js 100.00% <100.00%> (ø)
lib/sinon/colorizer.js 100.00% <ø> (ø)
lib/sinon/create-sandbox.js 100.00% <100.00%> (ø)
lib/sinon/sandbox.js 97.90% <100.00%> (+<0.01%) ⬆️
lib/sinon/spy-formatters.js 98.55% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fatso83
Copy link
Contributor Author

fatso83 commented Oct 25, 2023 •
edited

OK, somehow I managed to push to @sgoossens' repo and overwrite the original 🙈 Doing git push -u fatso83 followed by git push resulted in this magic:

[branch "feat/allow-limit-to-assertion-logs"]
        remote = fatso83
        pushRemote = https://github.com/sgoossens/sinon.git
        merge = refs/heads/feat/allow-limit-to-assertion-logs

I have no idea why that happened, but this means this PR is totally superfluous, so closing in favor of the original.

@fatso83 fatso83 closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable and Set Assertion Logging Limits
1 participant
@fatso83