fixed dynamic Lambda parameters #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*fixed calling System.Math *added (event based) extensibility for parameters and functions
*made Parameters dictionary private to improve performance *fixed binary operators *improved unit tests
|
closing cause it's stale |
It was stale because you never gave a feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #13 .
I know, there is a breaking change in API. This was the only solution I found to solve the performance issue in accessing parameters. For sure, we can discuss other solutions.
After pushing changes I found that github does not visualize renaming files. I fixed the name of LambdaExpressionVis(i)tor. Maybe, we need (temporary) rollback file rename to visualize the internal changes... :(