Fixed|libcommon: Applied undefined game rules loading legacy savegame

If the game plugin is not unloaded when the game mode changes then
the rules will be left in an undefined state prior to the new game
beginning. Although the game rules are always set when a new session
is begun. However, rather than beginning a new session, if a converted
legacy savegame is loaded which lacks a complete game ruleset then
the undefined game rules from the previous game session were applied
erroneously.

The game rules are explicitly cleared in G_CommonPreInit()

doomsday/plugins/common/include/gamesession.h

@@ -54,6 +54,9 @@ class GameSession : public de::game::Session
     /// Returns the singleton instance.
     static GameSession &gameSession();
 
+    /// Register the commands and variables of this module.
+    static void consoleRegister();
+
     bool hasBegun();
     bool savingPossible();
     bool loadingPossible();

doomsday/plugins/common/src/g_game.cpp

@@ -196,7 +196,6 @@ static gamestate_t gameState = GS_STARTUP;
 cvartemplate_t gamestatusCVars[] =
 {
     {"game-music", READONLYCVAR, CVT_INT, &gsvCurrentMusic, 0, 0, 0},
-    //{"game-skill", READONLYCVAR, CVT_INT, &gameRules.skill, 0, 0, 0},
     {"game-state", READONLYCVAR, CVT_INT, &gameState, 0, 0, 0},
     {"game-state-map", READONLYCVAR, CVT_INT, &gsvInMap, 0, 0, 0},
 #if !__JHEXEN__
@@ -366,6 +365,8 @@ static dd_bool quitInProgress;
 
 void G_Register()
 {
+    common::GameSession::consoleRegister();
+
     for(int i = 0; gamestatusCVars[i].path[0]; ++i)
     {
         Con_AddVariable(gamestatusCVars + i);
@@ -550,6 +551,9 @@ static void initSaveSlots()
  */
 void G_CommonPreInit()
 {
+    // Clear the game rules for the current session to their default values.
+    COMMON_GAMESESSION->rules() = GameRuleset();
+
     if(!gameMapUri)
     {
         gameMapUri = Uri_New();

doomsday/plugins/common/src/gamesession.cpp

@@ -1102,4 +1102,13 @@ String GameSession::savedUserDescription(String const &saveName)
     return ""; // Not found.
 }
 
+namespace {
+int gsvRuleSkill;
+}
+
+void GameSession::consoleRegister() //static
+{
+    C_VAR_INT("game-skill", &gsvRuleSkill, CVF_READ_ONLY|CVF_NO_MAX|CVF_NO_MIN|CVF_NO_ARCHIVE, 0, 0);
+}
+
 } // namespace common