-
-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(builder): use docker-buildx plugin to build for non-native platforms #316
base: master
Are you sure you want to change the base?
Conversation
👇 Click on the image for a new way to code review
Legend |
@@ -537,6 +537,30 @@ The `--dockerfile` option makes it possible to build a new minified image direct | |||
|
|||
The `--use-local-mounts` option is used to choose how the `docker-slim` sensor is added to the target container and how the sensor artifacts are delivered back to the master. If you enable this option you'll get the original `docker-slim` behavior where it uses local file system volume mounts to add the sensor executable and to extract the artifacts from the target container. This option doesn't always work as expected in the dockerized environment where `docker-slim` itself is running in a Docker container. When this option is disabled (default behavior) then a separate Docker volume is used to mount the sensor and the sensor artifacts are explicitly copied from the target container. | |||
|
|||
#### `docker-buildx` plugin | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is worth noting that the report will only report on the host platform's build. Are there any other caveats or edge cases you can think of that are worth noting here @kcq?
5482483
to
157521f
Compare
@estroz will this get merged? That's a big PR - would be a shame to leave it and let it have more conflicts 😉 |
any changes ? |
|
Thank you for the quick response will give that a try out |
Fixes #312
Supersedes #314 , which adds ~14 MB to the binary and a few new deps while this only adds ~3 MB and one new dep.
What
Leverage
docker buildx
for multi-platform output image buildsWhy
See #312
How Tested
Manually