Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Missing icon: gnome-aisleriot #95

Open
ubuntujaggers opened this issue Sep 28, 2018 · 6 comments
Open

Missing icon: gnome-aisleriot #95

ubuntujaggers opened this issue Sep 28, 2018 · 6 comments

Comments

@ubuntujaggers
Copy link

Hi @snwh,

gnome-aisleriot doesn't yet have a Suru icon:

image

I can fork here and submit a PR for my attempt if you're amenable to reviewing:

gnome-aisleriot svg

?

@snwh
Copy link
Owner

snwh commented Oct 3, 2018

Of course I'm amenable, I've always been open to PRs where I can review proposed icons (one at at time).

I like the direction of this icon you have, but the A❤️ on the largest icon would need to be positioned better within the bounding grid (press \ in Inkscape to show it, iirc) Alternatively, I'd try something along the lines of either:

  1. have "physical" cards as separate objects from the background as part of the pictogram
  2. or have "layers" like the calculator app icon and the lower layer be a card background

@ubuntujaggers
Copy link
Author

Brilliant, I'll work further on this and Mahjongg.

@ubuntujaggers
Copy link
Author

ubuntujaggers commented Oct 4, 2018

This is a version of the largest with some refined positioning:

gnome-aisleriot pixel grid svg

The "A" and the heart are positioned as follows:

  • Vertically centred relative to the whole squircle;
  • Horizontally centred within the left half of the squircle (so equidistant between the left edge of the squircle and its centre point);
  • The distances from the edges (including the icon centre as the right "edge") are all 24px which is a multiple of 4px.
  • The heart and the "A" are both 72x72px, again a multiple of 4px.

@snwh
Copy link
Owner

snwh commented Oct 11, 2018

That's largely the same positioning. It's too large and too close to the edges of the shape so proportionally it is off.

@ubuntujaggers
Copy link
Author

ubuntujaggers commented Oct 11, 2018

aisleriot smaller

Hotter, colder?

EDIT: When the position/proportion is right I'll make sure the nodes of the pictogram are at exact pixels.

@jnlucian
Copy link

@ubuntujaggers the pictogram should have a slight shadow as seen in the next icon
gnome-software

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants