Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X-editable vendor is not maintained #6147

Closed
VincentLanglet opened this issue Jun 16, 2020 · 6 comments
Closed

X-editable vendor is not maintained #6147

VincentLanglet opened this issue Jun 16, 2020 · 6 comments
Labels
Milestone

Comments

@VincentLanglet
Copy link
Member

VincentLanglet commented Jun 16, 2020

The live-edit function is based on the x-editable vendor
https://github.com/sonata-project/SonataAdminBundle/tree/3.x/src/Resources/public/vendor/x-editable

This library is not maintained anymore, the last commit was made in march 2019.
https://github.com/vitalets/x-editable#project-status

Moreover this library seems to not support bootstrap 4.
vitalets/x-editable#1159

We will maybe have to deprecate the live-edit function and remove it.

WDYT @sonata-project/contributors ?

@core23
Copy link
Member

core23 commented Jun 17, 2020

Is there any alternative / fork of lib?

👎 for removing this feature.

@jordisala1991
Copy link
Member

I did a search and there was not an obvious alternative, we might need to take a deeper look, -1 to remove this feature too.

@VincentLanglet
Copy link
Member Author

VincentLanglet commented Jun 17, 2020

There is no vote.
Nobody will vote +1 to remove a feature.

The real question is do we have an alternative if nobody maintain the project ?
vitalets/x-editable#610

@wbloszyk
Copy link
Member

We have alternative!!!

For now SonataAdminBundle is administration panel. Mybe we should start thinking diffrence? For me it is powerfull tools for generating CRUD. AbstractAdmin is big monolit what do not allow use this tools as much as they can be.

Back to subject. SonataAdminBundle have modal form (for create or edit object by AdminModelType). Create something simmilar is possible.

@VincentLanglet VincentLanglet added this to the 5.0 milestone Oct 26, 2020
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 25, 2021
@wbloszyk wbloszyk added keep and removed stale labels Apr 25, 2021
@VincentLanglet
Copy link
Member Author

Closing in favor of #7156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants