Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

produce more detailed error message when failing to load manifest from zipfile #3086

Open
ctb opened this issue Mar 19, 2024 · 0 comments
Open
Labels

Comments

@ctb
Copy link
Contributor

ctb commented Mar 19, 2024

in collection.rs, we have:

let manifest = Manifest::from_reader(storage.load("SOURMASH-MANIFEST.csv")?.as_slice())?;

which results in an error that looks like this,

Error: Path not found: SOURMASH-MANIFEST.csv

when a zipfile doesn't include a manifest.

I think we should produce a more specific error message to help guide the user.

related issues:

@ctb ctb added the rust label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant