RocksDB-based RevIndex gather functionality is broken.
#3139
Comments
2 tasks
bluegenes
pushed a commit
that referenced
this issue
May 10, 2024
This PR fixes an issue introduced in #2943 where we introduced a subtly broken calculation that uses the _current_ size of the query metagenome as the denominator for the `f_unique_to_query` calculation. Fixes #3137 This PR also adds some commented-out test code that demonstrates #3139 / sourmash-bio/sourmash_plugin_branchwater#322. That's something I haven't been able to debug, so I'd suggest fixing that independently - I'd rather fix _a_ problem _now_, rather than waiting until we can fix _multiple_ problems at some later indeterminate time :). ## Notes - [x] do we need to fix same problem in `linear.rs`? or just rename things per #3137? - [x] we should add some tests for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See sourmash-bio/sourmash_plugin_branchwater#322 for details.
The text was updated successfully, but these errors were encountered: