Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watcher panicked after editing file #2458

Open
matheus-consoli opened this issue May 6, 2024 · 1 comment
Open

Watcher panicked after editing file #2458

matheus-consoli opened this issue May 6, 2024 · 1 comment
Labels
kind/bug Something isn't working status/needs-triage

Comments

@matheus-consoli
Copy link
Contributor

matheus-consoli commented May 6, 2024

Describe the bug

The application crashes after editing a new file create from outside of Spacedrive.

Reproduction

  1. create a new Location
  2. let it open on the side
  3. create a new file in the location using another application (touch file)
  4. edit the file (vim file)

Expected behavior

The application should not crash

Platform and versions

>> pnpm --version && cargo --version && rustc --version
9.0.6
cargo 1.78.0 (54d8815d0 2024-03-26)
rustc 1.78.0 (9b00956e5 2024-04-29)

Stack trace

2024-05-06T22:37:54.692469Z ERROR sd_core: core/src/lib.rs:239: panicked at core/src/location/manager/watcher/utils.rs:942:13:
not yet implemented: file has changed in some way, re-identify it panic.file="core/src/location/manager/watcher/utils.rs:942" panic.column=13
fatal runtime error: failed to initiate panic, error 3

Additional context

The issue's origin is this todo!():

todo!("file has changed in some way, re-identify it")

I'll be happy to work on it, but I will just need some help with the expected behavior :)

@matheus-consoli matheus-consoli added kind/bug Something isn't working status/needs-triage labels May 6, 2024
@fogodev
Copy link
Contributor

fogodev commented May 6, 2024

Yeah, a concurrency issue that I mapped with this todo! but was hoping that it would never happen ):

Will give it a better look when possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working status/needs-triage
Projects
None yet
Development

No branches or pull requests

2 participants