Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSSLink values don't respect (non)uglyUrls #175

Closed
spf13 opened this issue Jan 19, 2014 · 6 comments
Closed

RSSLink values don't respect (non)uglyUrls #175

spf13 opened this issue Jan 19, 2014 · 6 comments
Assignees
@spf13
Labels
Bug Outdated

Comments

@spf13
Copy link
Contributor

spf13 commented Jan 19, 2014

No description provided.

@ghost ghost assigned spf13 Jan 19, 2014
@spf13 spf13 closed this as completed Feb 28, 2014
spf13 added a commit that referenced this issue Feb 28, 2014
@spf13
Reorganization of helpers. Centralized Url/Path logic. Fixed #175.
1422735
@abh
Copy link
Contributor

abh commented Feb 28, 2014

Nice, thank you. I had a patch for "url" front-matter not being properly respected but I didn't understand what the code was trying to do well enough to submit it. It's much cleaner now.

@glacjay
Copy link

glacjay commented Oct 28, 2015

When I set uglyUrls to true, {{ .RSSlink }} gives me http://localhost:1313/.xml instead of http://localhost:1313/index.xml. Is that caused by this bug?

@glacjay
Copy link

glacjay commented Oct 28, 2015

@spf13 I think RSS links should not be uglified even when the user specify uglyUrls = true, is that correct?

@spf13
Copy link
Contributor Author

spf13 commented Oct 28, 2015

correct

Steve Francia
http://stevefrancia.com
http://spf13.com
http://twitter.com/spf13

On Wed, Oct 28, 2015 at 9:16 AM, GlacJAY notifications@github.com wrote:

@spf13 https://github.com/spf13 I think RSS links should not be
uglified even when the user specify uglyUrls = true, is that correct?

—
Reply to this email directly or view it on GitHub
#175 (comment).

@glacjay
Copy link

glacjay commented Oct 29, 2015

@spf13 So I think I encounter a bug, when I set uglyUrls = true, hugo gives me an incorrect RSS link http://localhost:1313/.xml.

jmcfarlane added a commit to jmcfarlane/hugo that referenced this issue Dec 7, 2015
@jmcfarlane
Fix /.xml RSSLink when uglyurls are enabled
78894b6 
Prior to this commit the root url with uglyurls enabled is "/.xml".
This commit relates to gohugoio#175.
@jmcfarlane jmcfarlane mentioned this issue Dec 7, 2015
Closed
spf13 pushed a commit that referenced this issue Jan 4, 2016
@jmcfarlane @spf13
Fix /.xml RSSLink when uglyurls are enabled
b1f2b43 
Prior to this commit the root url with uglyurls enabled is "/.xml".
This commit relates to #175.
tychoish pushed a commit to tychoish/hugo that referenced this issue Aug 13, 2017
@jmcfarlane @tychoish
Fix /.xml RSSLink when uglyurls are enabled
b60626b 
Prior to this commit the root url with uglyurls enabled is "/.xml".
This commit relates to gohugoio#175.
@anthonyfok anthonyfok mentioned this issue Mar 8, 2018
Closed
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@spf13 spf13

Labels
Bug Outdated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@abh @spf13 @glacjay