Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add md5 and sha1 template functions #1932

Closed
wants to merge 1 commit into from
Closed

Add md5 and sha1 template functions #1932

wants to merge 1 commit into from

Conversation

digitalcraftsman
Copy link
Member

Fixes #1910.

@digitalcraftsman
Copy link
Member Author

@bep since the template functions' name would conflict with the corresponding package names I added an _ as prefix. Let me know if you're not happy with the way how the conflict is handled.

@bep
Copy link
Member

bep commented Mar 7, 2016

an _ as prefix.

That's fine. But you might add the error case to the tests (see the expect false interface{} construct used elsewhere).

Also add the two functions to the "smoke test at the top of the file".

@digitalcraftsman
Copy link
Member Author

I updated the test file accordingly.

@bep
Copy link
Member

bep commented Mar 10, 2016

Merged in 94c3825

@bep bep closed this Mar 10, 2016
@digitalcraftsman
Copy link
Member Author

Thanks.

@digitalcraftsman digitalcraftsman deleted the tplfuncs/hashing branch March 30, 2016 16:10
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add hash template functions
2 participants