Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added htmlescape and htmlunescape template functions #2287

Merged
merged 1 commit into from
Jul 18, 2016

Conversation

ghost
Copy link

@ghost ghost commented Jul 18, 2016

See #2286

@bep
Copy link
Member

bep commented Jul 18, 2016

Looks almost very good:

  1. The naming standard is camel casing, so it should be htmlEscape and htmlUnescape.
  2. Fix the commit message (add vs added)

These functions allow trivial escaping and unescaping of HTML entities,
and make it far easier to compose other functions for the creation of
parameterised URLs.
@ghost
Copy link
Author

ghost commented Jul 18, 2016

Sorry for that! Fixed, after some embarrassing rebase shenanigans.

@bep bep merged commit 20555b1 into gohugoio:master Jul 18, 2016
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant