Add vendoring with govendor #2461
Conversation
moorereason
force-pushed
the
govendor
branch
from
0a9da23
to
bd4be08
Compare
|
The vendor.json file; is that a standard format? |
|
There is no standard format. That's govendor's format. The only standard is that the Go tools look for vendored packages in the |
|
Tagged for 0.17. FIxes #2119. |
|
I merged this as it does solve the problem ... but we should do an evaluation of the vendoring options for 0.18. |
|
When I read the release notes for 0.17, I just expected the code under vendor/ to be checked in. Should |
| @@ -34,39 +32,45 @@ docker: | |||
| docker cp hugo-build:/go/bin/hugo . | |||
| docker rm hugo-build | |||
|
|
|||
| govendor: | |||
| go get -u github.com/kardianos/govendor | |||
| go install github.com/kardianos/govendor | |||
There was a problem hiding this comment.
FYI
"Get downloads the packages named by the import paths, along with their
dependencies. It then installs the named packages, like 'go install'." -go get -h
There was a problem hiding this comment.
Which is to say the go install line is superfluous.
It still appears here atm: https://github.com/spf13/hugo/blob/master/Makefile#L37
There was a problem hiding this comment.
You're right. I was looking at this on my phone and misunderstood where your comment was in the Makefile. The go install does indeed need to be removed.
|
The Makefile has already been fixed in master. And yes, we may need to update the README. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Doesn't check in vendored packages. Rewrites Makefile to use govendor helpers.