New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression: IsTranslated can be wrong for "node types" #2812
Comments
Hey and thanks for the bug report. It is the In your case you can just remove this:
If you want to replace that conditional until we get a fix for this, you can do something like this:
|
Note to self, the |
OK, now I see it. IsTranslated is wrong for sites with only 1 translation. |
Happy that it helped! And thanks for your reactivity! |
The new logic for creating Page objects from old node types didn't include itself in the translation logic, so `IsTranslated` returned falsely false for sites with only two languages. The `AllTranslations` method also returned too few pages in that case. This commit fixes that. Fixes gohugoio#2812
The new logic for creating Page objects from old node types didn't include itself in the translation logic, so `IsTranslated` returned falsely false for sites with only two languages. The `AllTranslations` method also returned too few pages in that case. This commit fixes that. Fixes #2812
The new logic for creating Page objects from old node types didn't include itself in the translation logic, so `IsTranslated` returned falsely false for sites with only two languages. The `AllTranslations` method also returned too few pages in that case. This commit fixes that. Fixes #2812
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Hello and thanks for the great work :)
I have a quick question (referring to this issue )
Our website is printing a little icon "fr" link for french translation of the home page.
(You can see it in action here: https://indie.host/ on the top right)
This was built with 0.17.
I just tried with 0.18, and the "fr" link disappeared.
I checked the value of "IsTranslated" and it is to false.
Could you tell us what happened during the upgrade, and what can we do to fix?
You can find the code for the website here:
https://git.indie.host/meta/website/tree/master
Thanks a lot!
The text was updated successfully, but these errors were encountered: