Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CanonifyUrls does not canonicalize urls in RSS #725

Closed
popthestack opened this issue Dec 18, 2014 · 3 comments
Closed

CanonifyUrls does not canonicalize urls in RSS #725

popthestack opened this issue Dec 18, 2014 · 3 comments
Milestone

Comments

@popthestack
Copy link
Contributor

In my config: CanonifyUrls = true

In rss.xml: {{ .Content | html }}

Linking to another post: [nifty thing I wrote](/article/post-slug/)

Rendered post: <a href="http://localhost:1313/article/post-slug/">nifty thing I wrote</a>

Rendered index.xml: &lt;a href=&#34;/article/post-slug/&#34;&gt;nifty thing I wrote&lt;/a&gt;

Alternately, something like CanonifyUrlsInRSS would be handy, since that's really where I want canonicalized urls anyway.

(I'm brand new to Go and Hugo, but given time I'm willing to make this a PR.)

@aglossa
Copy link

aglossa commented Dec 18, 2014

Same problem, even if I am even more a newbie and don't know from where the rss (or sitemap) templates come from.

PS: in my installation, I use CanonifyUrls = false and relative links.

@bep bep added the Bug label Dec 20, 2014
@anthonyfok anthonyfok self-assigned this Jan 17, 2015
@anthonyfok anthonyfok added this to the v0.13 milestone Jan 17, 2015
@anthonyfok anthonyfok removed their assignment Jan 17, 2015
@anthonyfok
Copy link
Member

Awesome! @popthestack has fixed the bug very nicely with commit 7dacc99 in #728! Thank you so much!

That means there is one less problem we have to deal with in #789 in our quest to produce the perfect RSS feed. :-)

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants