Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Popup Lyrics] Japanese and Korean lyrics transliteration #2386

Open
surya27895 opened this issue Jun 1, 2023 · 6 comments
Open

[Popup Lyrics] Japanese and Korean lyrics transliteration #2386

surya27895 opened this issue Jun 1, 2023 · 6 comments

Comments

@surya27895
Copy link

πŸ“ Provide a description of the new feature

well, since spicetify has this features on lyrics plus, I think it will be great if can also implement on popup lyrics

βž• Additional Information

No response

@Patrick-orz
Copy link

For people looking at this issue, the following repo might suit your needs:
Patrick-orz/PopupLyrics-Plus

@surya27895
Copy link
Author

For people looking at this issue, the following repo might suit your needs: Patrick-orz/PopupLyrics-Plus

Wow thanks!! I will give it try

@Patrick-orz
Copy link

For people looking at this issue, the following repo might suit your needs: Patrick-orz/PopupLyrics-Plus

Wow thanks!! I will give it try

I wonder if it worked for you?

@surya27895
Copy link
Author

surya27895 commented Sep 17, 2023

For people looking at this issue, the following repo might suit your needs: Patrick-orz/PopupLyrics-Plus

Wow thanks!! I will give it try

I wonder if it worked for you?

it works, but still buggy and caused few crash, memory leak I guess?
I think I will wait until few updates more, ah and it not work as I expected, I hope language detection can work automatically, but great job for initial release!!! hope the development will continue.

@rxri
Copy link
Member

rxri commented Nov 12, 2023

Adding translator to popupLyrics will make the readability of the code much worse because we're limited to one file. PopupLyrics are somewhat intended to be lightweight. I understand that you want to see this feature but unfortunately I did not see people asking for this so I don't know if it's really needed?

@ok-coder1
Copy link

It is not transliteration it is translation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants