Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coupon codes are ignored when paying with PayPal #181

Open
Dethon opened this issue Dec 2, 2017 · 0 comments
Open

Coupon codes are ignored when paying with PayPal #181

Dethon opened this issue Dec 2, 2017 · 0 comments

Comments

@Dethon
Copy link
Contributor

Dethon commented Dec 2, 2017

As title says, If you try to use a coupon code in the payment selection page and choose PayPal as your payment method, the coupon is ignored.

This happens because the "next step" button you click when choosing PayPal is not actually a submit button, so the javascript code tasked with coupon application is not triggered. The easy way to fix it is adding some coupon managing code before calling checkout.paypal.initAuthFlow(); in _payment.html.erb

I already have a patch working, so I'll submit a PR after doing some more testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant