Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SD-1290] Handle PayPal Payment Method on the Checkout / Payment page #255

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[SD-1290] Handle PayPal Payment Method on the Checkout / Payment page #255

wants to merge 1 commit into from

Conversation

mad-eel
Copy link
Contributor

@mad-eel mad-eel commented May 31, 2021

TODO:

  • pass shipping address to PayPal
  • handle the result and store the payment nonce on the Spree side
  • adjust controller if needed
  • extract Braintree js side from partials to assets

@mad-eel mad-eel changed the title WIP: handle PayPal Express on the Checkout / Payment page [SD-1290] Handle PayPal Express on the Checkout / Payment page May 31, 2021
@mad-eel mad-eel linked an issue May 31, 2021 that may be closed by this pull request
Payment "source" is nil on PayPalExpress #241
Open
@mad-eel mad-eel changed the title [SD-1290] Handle PayPal Express on the Checkout / Payment page [SD-1290] Handle PayPal Payment Method on the Checkout / Payment page May 31, 2021
terfender added a commit to terfender/spree_braintree_vzero that referenced this pull request Oct 30, 2021
@terfender
Merged request spree-contrib#255
0b3342b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Payment "source" is nil on PayPalExpress
1 participant
@mad-eel