Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching causes the "Leave a review" link to show up only sometimes. #126

Open
ghost opened this issue Nov 18, 2014 · 4 comments
Open

Caching causes the "Leave a review" link to show up only sometimes. #126

ghost opened this issue Nov 18, 2014 · 4 comments

Comments

@ghost
Copy link

ghost commented Nov 18, 2014

Depending on when the cache was made, i.e. if the current_user was logged in or not, the saved html will sometimes have a link to leave a review, sometimes not.

@JDutil
Copy link
Member

JDutil commented Nov 26, 2014

May need to change the form to be loaded by ajax or move the cache key https://github.com/spree/spree/blob/master/frontend/app/views/spree/products/show.html.erb#L1 somewhere else that only wraps the product form in a way that you can still insert things with deface.

@ghost
Copy link
Author

ghost commented Nov 26, 2014

@JDutil I solved this by just always displaying the link. If you are not logged in, you will get redirected to log in, then afterwards redirected back to give the review

@ghost
Copy link
Author

ghost commented Nov 26, 2014

@JDutil I can PR it if that sounds like a good solution.,

@JDutil
Copy link
Member

JDutil commented Nov 26, 2014

Sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant