Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resubmission of incomplete publications fails silently if listener is not found #549

Closed
benjaminknauer opened this issue Apr 10, 2024 · 0 comments
Closed

Resubmission of incomplete publications fails silently if listener is not found #549

benjaminknauer opened this issue Apr 10, 2024 · 0 comments
Assignees
@odrotbohm
Labels
in: event publication registry Event publication registry type: improvement Minor improvements
Milestone
1.2

Comments

@benjaminknauer
Copy link
Contributor

Hi!

We encountered this problem in production, caused by a refactoring change of the listener method.

Only after enabling the debug logs like so, we got some more information:

logging:
  level:
    org.springframework.modulith.events.support.PersistentApplicationEventMulticaster: DEBUG

Listener de.myapp.MyService.testMethod(de.myapp.TestEvent) not found!

In my opinion, Modulith should not fail silently but should produce an error log.
@benjaminknauer benjaminknauer mentioned this issue Apr 10, 2024
Closed
@odrotbohm odrotbohm added this to the 1.2 milestone Apr 29, 2024
@odrotbohm odrotbohm self-assigned this Apr 29, 2024
@odrotbohm odrotbohm added in: event publication registry Event publication registry type: improvement Minor improvements labels Apr 29, 2024
odrotbohm pushed a commit that referenced this issue Apr 29, 2024
@benjaminknauer @odrotbohm
GH-549 - Use error log in PersistentApplicationEventMulticaster if li…
32f4cbc 
…stener not found.

Related pull request: GH-548.
@odrotbohm odrotbohm changed the title Resubmit incomplete publications fails silently if listener is not found Resubmission of incomplete publications fails silently if listener is not found Apr 29, 2024
@odrotbohm odrotbohm mentioned this issue Apr 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
in: event publication registry Event publication registry type: improvement Minor improvements
Projects
None yet
Milestone
1.2
2 participants
@odrotbohm @benjaminknauer