Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 8 date/time type java.time.Instant not supported by default #563

Open
thestroke82 opened this issue Apr 24, 2024 · 3 comments
Open
Assignees
Labels
in: event publication registry Event publication registry meta: waiting for feedback Waiting for feedback of the original reporter

Comments

@thestroke82
Copy link

The serializer needs datatype-jsr310.
I apologize in advance if it's already been reported.

@odrotbohm
Copy link
Member

I am assuming you're referring to the Jackson ObjectMapper used to serialize the event instances? That one is picked up from Boot's default setup. The fallback we declare picks up all Module beans from the ApplicationContext. In other words, if the JSR-310 module is on the classpath it should be registered through Boot.

If that doesn't work, would you mind creating a minimal reproducer for us to investigate?

@odrotbohm odrotbohm self-assigned this Apr 29, 2024
@odrotbohm odrotbohm added in: event publication registry Event publication registry meta: waiting for feedback Waiting for feedback of the original reporter labels Apr 29, 2024
@thestroke82
Copy link
Author

thestroke82 commented Apr 29, 2024

Yes I am referring to the Jackson ObjectMapper. In fact jackson-datatype-jsr310 was already present in the classpath, but i still got the error.
I'll try to reproduce it but really it was no special configuration: some standard Boot starters, js310 and spring-modulith-events-api . I get the error when I try to publish an event.

@odrotbohm
Copy link
Member

You might want to debug into JacksonEventSerializationConfiguration.jacksonEventSerializer(…) and see whether the ObjectProvider contains a preconfigured instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: event publication registry Event publication registry meta: waiting for feedback Waiting for feedback of the original reporter
Projects
None yet
Development

No branches or pull requests

2 participants