This repository has been archived by the owner on May 31, 2022. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Prevent recursive placeholders in whitelabel views
This change prevents placeholders in model values from being recursively replaced (which is a feature of the placeholder utilities in Spring Core), so that user-provided data (e.g. an invalid response_type or a leaky exception message) cannot be used to inject SpEL into the view. N.B. this only affects apps that are using the whitelabel views for approval and error pages (i.e. probably nothing in production).
- Loading branch information
Dave Syer
committed
Mar 12, 2016
1 parent
4f01e4a
commit fff77d3
Showing
2 changed files
with
75 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67 changes: 67 additions & 0 deletions
67
...h2/src/test/java/org/springframework/security/oauth2/provider/endpoint/SpelViewTests.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
/* | ||
* Copyright 2012-2015 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.springframework.security.oauth2.provider.endpoint; | ||
|
||
import static org.junit.Assert.assertEquals; | ||
|
||
import java.util.Collections; | ||
import java.util.HashMap; | ||
import java.util.Map; | ||
|
||
import org.junit.Test; | ||
import org.springframework.mock.web.MockHttpServletRequest; | ||
import org.springframework.mock.web.MockHttpServletResponse; | ||
|
||
/** | ||
* @author Dave Syer | ||
* | ||
*/ | ||
public class SpelViewTests { | ||
|
||
private SpelView view; | ||
|
||
private MockHttpServletResponse response = new MockHttpServletResponse(); | ||
private MockHttpServletRequest request = new MockHttpServletRequest(); | ||
|
||
@Test | ||
public void sunnyDay() throws Exception { | ||
view = new SpelView("${hit}"); | ||
view.render(Collections.singletonMap("hit", "Ouch"), request, response); | ||
assertEquals("Ouch", response.getContentAsString()); | ||
} | ||
|
||
@Test | ||
public void nonRecursive() throws Exception { | ||
view = new SpelView("${hit}"); | ||
view.render(Collections.singletonMap("hit", "${ouch}"), request, response); | ||
// Expressions embedded in resolved values do not resolve recursively | ||
assertEquals("${ouch}", response.getContentAsString()); | ||
} | ||
|
||
@Test | ||
public void recursive() throws Exception { | ||
// Recursive expressions in the template resolve | ||
view = new SpelView("${${hit}}"); | ||
Map<String,Object> map = new HashMap<String, Object>(); | ||
map.put("hit", "me"); | ||
map.put("me", "${ouch}"); | ||
view.render(map, request, response); | ||
// But expressions embedded in resolved values do not | ||
assertEquals("${ouch}", response.getContentAsString()); | ||
} | ||
|
||
} |
fff77d3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice One 👍