Skip to content

Commit

Permalink
fix #3957
Browse files Browse the repository at this point in the history
  • Loading branch information
rt committed Aug 23, 2013
1 parent 9462149 commit b0295a7
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion rts/Rendering/UnitDrawer.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -842,7 +842,8 @@ void CUnitDrawer::DrawIcon(CUnit* unit, bool useDefaultIcon)
}

// make sure icon is above ground (needed before we calculate scale below)
const float h = ground->GetHeightAboveWater(pos.x, pos.z, false);
const float h = ground->GetHeightReal(pos.x, pos.z, false);

if (pos.y < h) {
pos.y = h;
}
Expand Down

5 comments on commit b0295a7

@cleanrock
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit skeptical to this change. Icons of units below water are less visible (color is muted) and transported units (in BA at least) will not show icon. If we keep this subsurface pos i think we should make sure icon has same color as above water icons.

@cleanrock
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its considerable worse as it is now after this commit.
This needs to be fixed before 95 release. "fixed" can mean revert of this commit.

@abma
Copy link
Contributor

@abma abma commented on b0295a7 Aug 25, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

threadpool can be easily disabled...

@silentwings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason you're not seeing icons of units inside of trans in BA might be because we have a gadget to hide them (I would link it, but our repo is down right now).

@cleanrock
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

silentwings,
You are right, icon for transported unit is visible in XTA at least.
The big thing is icons for units below water surface are barely visible, test on Tempest and you will see what i mean.

Please sign in to comment.