-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SC.AlertPane buttons button height: 'auto' is not 24px #1372
Comments
was able to find the solution. I made a bare bones project and deployed through the command windows command line loadded the browser to localhost4020:/appname and the button appeared as intended. Loaded the app i am working on through the tomee server and discovered. but tomee server app was using .ace.dark.sc-regular-size.button .sc-button-label { we pulled the static folder directly off of github and no should have made any changes to it on our end, so this could be an error for someone else down the road. If you do not want to touch the stylesheet in the static just put this into the css file. .ace.appname.dark.sc-regular-size.button .sc-button-label { Hope this helps someone else down the road that may encounter the same problem. -Brandon Philpot |
Peculiar indeed. You tested this with the Abbot buildtools? As we are moving towards switching to a new set of build tools written in SC and NodeJS (see https://github.com/sproutcore/build-tools), would you mind trying to see whether this problem also happens there? |
Talked to my boss and we had actually built it with a fairly old version of ruby, and just kept the working build zip to use. My boss told me to go ahead and redo the build with the abbot buildtools, when ever I have some free time. Not sure when that will be completed. It will be between projects, I will test to see if the error occurs again and post the results. |
Just to be sure: Abbot is the ruby buildtools which gets installed when you install through The newer buildtools can be installed through npm, but do require a recent version of sproutcore (which is bundled by default) as well as a different configuration format and a slightly different feature set, which might require some adjustments in your project. |
Ok, cool thanks for the heads up, looks like I have some research to do to make sure everything is running smoothly and correctly. |
You're very welcome. Feel free to drop in on our IRC channel (#sproutcore on freenode.net) or through Gitter (https://gitter.im/sproutcore/sproutcore) if you think that will help. |
When using the alert pane the buttons display the first 2 or 3px of the next png under the button. If I go into the "/sproutcore/desktop/en/current/javascript.js" and change the height from "height: 'auto'" to "height: 24" it displays correctly. Is this a bug? Or could I manually set the height from auto to 24px without making the change in the javascript file?
The text was updated successfully, but these errors were encountered: