Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SC.RecordAttribute Array transform leaks KVO properties to the underlying array #1413

Open
mauritslamers opened this issue Feb 9, 2017 · 0 comments

Comments

@mauritslamers
Copy link
Member

The definition of the Array transform of SC.RecordAttribute (at https://github.com/sproutcore/sproutcore/blob/master/frameworks/datastore/models/record_attribute.js#L454) defines the observesChildren property.
Because of this property, the general toType will add observers to the value (see https://github.com/sproutcore/sproutcore/blob/master/frameworks/datastore/models/record_attribute.js#L233).

Because of the value here being a native array, it results in adding KVO properties to the array. This causes the record hash to be no longer convertible to JSON because of the circular structures the KVO system adds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant