Make Function#argumentNames use Function.prototype.toString. [#186 st…

…ate:resolved]
prototypejs · Jun 26, 2008 · 05a1143 · 05a1143 · tobie · Sep 8, 2008
1 parent 6f79c78
commit 05a1143
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,3 +1,5 @@
+* Make Function#argumentNames use Function.prototype.toString. [Garrett Smith, jddalton, kangax]
+
 * Rename variable in Form.Element.Serializers.select. [jddalton]
 
 * Replace browser sniffing with capability detection in IE fork of String#unescapeHTML. [kangax]

diff --git a/src/base.js b/src/base.js
@@ -158,9 +158,10 @@ Object.extend(Object, {
 });
 
 Object.extend(Function.prototype, {
-  argumentNames: function() {
-    var names = this.toString().match(/^[\s\(]*function[^(]*\(([^\)]*)\)/)[1]
-      .replace(/\s+/g, '').split(',');
+  argumentNames: function() {  
+    var names = Function.prototype.toString.call(this)
+     .match(/^[\s\(]*function[^(]*\(([^\)]*)\)/)[1]
+     .replace(/\s+/g, '').split(',');
     return names.length == 1 && !names[0] ? [] : names;
   },