@@ -1,3 +1,5 @@ +* Ensure Selector.handlers.id finds the proper element even when it's not attached to the document. [jddalton] + * Fix Position.within in IE. [jddalton] * Fix the deprecated Position.withinIncludingScrollOffsets. [jddalton] CHANGELOG @@ -467,16 +467,8 @@ Object.extend(Selector, { id: function(nodes, root, id, combinator) { var targetNode = $(id), h = Selector.handlers; if (!targetNode) { - var needsToSearch = false; - // IE and Opera don't find elements by ID if they're not attached - // to the document. - if (Prototype.Browser.IE && (root.sourceIndex < 1 || - root === document)) { - needsToSearch = true; - } else if (Prototype.Browser.Opera && - (root.compareDocumentPosition(document) & 1) === 1) { - needsToSearch = true; - } + var needsToSearch = root === document || root.sourceIndex < 1 || + !Element.descendantOf(root, document.documentElement); if (needsToSearch) { var nodes = root.getElementsByTagName('*'); src/selector.js 5fffac9ded0fc1b41429a876c3f0c62088a00189 Andrew Dupont prototype@andrewdupont.net http://github.com/sstephenson/prototype/commit/4b2913c79f9d57e96360294d7a134593a8819c91 4b2913c79f9d57e96360294d7a134593a8819c91 2008-07-16T11:08:52-07:00 2008-07-16T11:08:52-07:00 Ensure Selector.handlers.id finds the proper element even when it's not attached to the document. [#198 state:resolved] 838ab35060e38ec83507438ffb7c6f187f12a430 Andrew Dupont prototype@andrewdupont.net