Coerce Opera's version string into a number whenever we need to sniff. [

#163 state:resolved]
prototypejs · Jun 26, 2008 · be24bf9 · be24bf9
1 parent ba5edc3
commit be24bf9
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,3 +1,5 @@
+* Coerce Opera's version string into a number whenever we need to sniff. [Sam Holman, jddalton]
+
 * Amend previous checkin to restrict fix to Opera 9.5. [Andrew Dupont]
 
 * Fix issue where Opera gets confused by complex selectors in $$. [Paulo Pereira, Andrea Baron, jddalton] 

diff --git a/src/dom.js b/src/dom.js
@@ -1331,8 +1331,15 @@ document.viewport = {
     var dimensions = { }, B = Prototype.Browser;
     $w('width height').each(function(d) {
       var D = d.capitalize();
-      dimensions[d] = (B.WebKit && !document.evaluate) ? self['inner' + D] :
-        (B.Opera && opera.version() < 9.5) ? document.body['client' + D] : document.documentElement['client' + D];
+      if (B.WebKit && !document.evaluate) {
+        // Safari <3.0 needs self.innerWidth/Height
+        dimensions[d] = self['inner' + D];
+      } else if (B.Opera && parseFloat(window.opera.version()) < 9.5) {
+        // Opera <9.5 needs document.body.clientWidth/Height
+        dimensions[d] = document.body['client' + D]
+      } else {
+        dimensions[d] = document.documentElement['client' + D];
+      }
     });
     return dimensions;
   },