Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fee estimation API when creating vote-for-aggregate-key transactions #4543

Closed
hstove opened this issue Mar 14, 2024 · 0 comments
Closed
Assignees
Labels
3.0 feature Brand new functionality. New pages, workflows, endpoints, etc. signer

Comments

@hstove
Copy link
Contributor

hstove commented Mar 14, 2024

During epoch 2.5, signers are required to pay a transaction fee when broadcasting their vote-for-aggregate-key transactions. At the moment, this fee is decided from the field tx_fee_ustx in the signer's config file.

A more robust approach would be to call the node's fee estimation API and use that as the fee.

Some questions:

  • Which fee estimate should be used (low/medium/high)? medium
  • Should this be configurable (aka opt-in or opt-out)? opt-out
  • Should there be a "max fee" option? yes
@hstove hstove added feature Brand new functionality. New pages, workflows, endpoints, etc. signer labels Mar 14, 2024
@saralab saralab added the 3.0 label Mar 15, 2024
@jferrant jferrant self-assigned this Mar 22, 2024
@jferrant jferrant closed this as completed Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0 feature Brand new functionality. New pages, workflows, endpoints, etc. signer
Projects
Archived in project
Development

No branches or pull requests

3 participants