Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert persistent vs ephemeral cell IDs #1354

Open
sourishkrout opened this issue May 15, 2024 · 1 comment · May be fixed by #1359
Open

Invert persistent vs ephemeral cell IDs #1354

sourishkrout opened this issue May 15, 2024 · 1 comment · May be fixed by #1359
Assignees
Labels
bug Something isn't working

Comments

@sourishkrout
Copy link
Member

Sort of revert what we did in this PR: #938

And then salvaged in this PR: #1252

The remaining problem right now is that when cell IDs are turned off we have to remove them from the document. By having the core logic rely on the ephemeral IDs and make them the same as the persistent ones (already the case). Cell IDs will be optional again no matter whether they are persistently present or not.

@sourishkrout sourishkrout added the bug Something isn't working label May 15, 2024
@sourishkrout
Copy link
Member Author

When identity is turned off for cells, saving this file should write exactly the same, as in don't add or remove any IDs from cells.

Image

In the current implementation it will either add IDs to all cells or remove them from all cells.

@pastuxso pastuxso linked a pull request May 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants