Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a vendor check for dependencies #556

Closed
mandrigin opened this issue Jan 18, 2018 · 1 comment
Closed

Create a vendor check for dependencies #556

mandrigin opened this issue Jan 18, 2018 · 1 comment

Comments

@mandrigin
Copy link
Contributor

mandrigin commented Jan 18, 2018

Problem

Currently, our CI process doesn't ensure that the dependencies in vendor folder are the same as in Gopkg.lock file.

Implementation

The script should run dep ensure and then check if anything was changed in the vendor directory. If so — fail the pipeline.

The command to run this script should be make vendor-check

See this thread for more practical advice.

1st party implementation is coming to dep: golang/dep#121.

Acceptance Criteria

  1. A makefile target is created that fails if there is something in a vendor folder that isn't in Gopkg.lock. Or if dep ensure changes something in the vendor folder.

  2. .travis.yml is updated to have a step of checking dependencies before building or running any tests. (NOTE: Travis restarts builds on every push. If you need to force restarting it and have no changes to commit, just alter the latest commit message with git commit --amend and push. That should do the trick).

@status-open-bounty
Copy link

status-open-bounty commented Jan 29, 2018

Balance: 0.000000 ETH
Tokens: SNT: 735.00
Contract address: 0x6d179a2fa3a800baa30c1d0aa32b287d5450b260
Network: Mainnet
Paid to: azer
Visit https://openbounty.status.im to learn more.

@andytudhope andytudhope moved this from bounty-awaiting-approval to Bounty Open in Status Bounty Tracker Jan 29, 2018
@pablanopete pablanopete moved this from Bounty Open to PR Submitted in Status Bounty Tracker Feb 8, 2018
@pablanopete pablanopete moved this from PR Submitted to Merged & Confirmed in Status Bounty Tracker Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status Bounty Tracker
  
Merged & Confirmed
Development

No branches or pull requests

3 participants