Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portuguese: Portugal and Brazil #78

Open
horus68 opened this issue Jul 3, 2023 · 5 comments
Open

Portuguese: Portugal and Brazil #78

horus68 opened this issue Jul 3, 2023 · 5 comments

Comments

@horus68
Copy link

horus68 commented Jul 3, 2023

Portugal and Brazil are different countries with a common language that do have differences being the portuguese from Portugal the reference for the language in other countries.

When naming countries there are some diferences but you only have a "pt" folder. Some of the names used there are not ok for Portugal. Example you have "Irã" (ok for Brazil) but in Portugal it needs to be "Irão".
So, I request to duplicate the folder "pt" (Portuguese) to get a pt-PT and pt-BR versions
[world_countries/data
/countries/ ](https://github.com/stefangabos/world_countries/tree/master/data/countries/pt)

I can edit the pt-PT version of the files to fix the issues

@stefangabos
Copy link
Owner

Thanks for bringing this to my attention!

All the names are taken automatically from Wikipedia. In this case, these are taken from here (click on the Códigos ISO 3166-1 por nome de país).

I will gladly create the pt-PT and pt-BR versions but I don't want these to be kept up to date manually. I run a script every now and then that brings everything up to date so, if you could give me a reliable source for country names used in Portugal I could automatically use it to keep everything updated.

Thanks!

@horus68
Copy link
Author

horus68 commented Jul 3, 2023

Wikipedia do not have pt-PT and pt-BR versions so its first to edit (or last to change) wins!
I posted a question there but I don't hope it gets any attention.

The ISO 3166 official translated file is a closed edition!

@stefangabos
Copy link
Owner

stefangabos commented Jul 3, 2023

actually, asking questions on wikipedia worked for me very well in the past - everywhere I did so, I got quick answers.
as an alternative solution, I do have some hard-coded values that were provided by people over time, like your case with "Irão". if that is the only issue, i can hard-code that value and it will never change if updated

@horus68
Copy link
Author

horus68 commented Jul 3, 2023

Ok, will wait for discussion on Wikipedia. In a week I will get back to this!

@stefangabos
Copy link
Owner

any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants