Replace all uses of Path with Utf8Path

[willemneal]

What problem does your feature solve?

https://docs.rs/camino/latest/camino/ ensures that the file path is utf8 and works on windows. Path uses OsSr under the hood, which allows non-utf8 strings. This is why there is pain when trying to go from a Path back to a &str. You either get an Option or a lossy string with invalid characters replaced with invalid character.

Enforcing utf-8 upfront means that .unwrap_unchecked can safely be used.

What would you like to see?

All instances of Path and PathBuf replaced with Utf8Path and Utf8PathBuf.

What alternatives are there?

[leighmcculloch]

This is why there is pain when trying to go from a Path back to a &str. You either get an Option or a lossy string with invalid characters replaced with invalid character.

Where is this causing problems in the CLI?

[willemneal]

Here are 24 examples of .to_string_lossy. We don't have any tests that cover this, but it definitely wouldn't be a problem for Utf8Path.
https://sourcegraph.com/search?q=context:global+repo:%5Egithub%5C.com/stellar/soroban-cli%24+.to_string_lossy&patternType=keyword&sm=0

[willemneal]

Also if we ever have paths as strings in config files we would likely encode with utf8.