Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the IFeaturesCollection #79

Open
stevejgordon opened this issue May 16, 2020 · 3 comments
Open

Support the IFeaturesCollection #79

stevejgordon opened this issue May 16, 2020 · 3 comments
Labels
design-required Requires API design and planning before this can be added. under consideration
Milestone

Comments

@stevejgordon
Copy link
Owner

There may be value in registering something into the IFeaturesCollection such that downstream middleware can inspect the status of the correlation ID and make decisions based upon it. This feels like a reasonable use of that concept.

Today it's possible to grab the accessor and acting on the value directly but that may be less convenient for downstream middleware.

Useful metadata may include:

  • Was a value provided by the caller?
  • Was the value valid?
  • Was the value generated by the library?

The most useful may be the valid/invalid case.

@stevejgordon stevejgordon added under consideration design-required Requires API design and planning before this can be added. labels May 16, 2020
@stevejgordon stevejgordon added this to the v3.1 milestone May 16, 2020
@tomkerkhove
Copy link

We use a similar approach: https://github.com/arcus-azure/arcus.webapi/blob/master/src/Arcus.WebApi.Logging/Correlation/CorrelationMiddleware.cs

That way it's super convenient for others, but you're locked in to the HTTP stack which is also a downside.

@k2ibegin
Copy link

k2ibegin commented Jun 9, 2020

Does correlation ID provide as good alternative to what Rebus correlation ID mechanism provides ? Can I also use this for non HTTP based worker microservices in combination with ASP NET core web api microservices ?

@stevejgordon
Copy link
Owner Author

@k2ibegin Your question would be best as a new issue since it's not really related to this one. I've not used Rebus to compare what that provides. This library is a simple option for a basic correlation header which can flow to downstream HTTP calls. You can apply this to non HTTP work but you need to link it together. We do this for AWS queues and we often attach the correlation ID as an attribute on the msg which we pull off at the other end. I have considering an integration package for that but it's fairly trivial code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-required Requires API design and planning before this can be added. under consideration
Projects
None yet
Development

No branches or pull requests

3 participants