Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICorrelationContextAccessor has setter #92

Open
MatthewLymer opened this issue Sep 2, 2020 · 1 comment
Open

ICorrelationContextAccessor has setter #92

MatthewLymer opened this issue Sep 2, 2020 · 1 comment

Comments

@MatthewLymer
Copy link

MatthewLymer commented Sep 2, 2020

Hello and thank you for the awesome library, it's very useful for me!

One thing I noticed is that ICorrelationContextAccessor has a setter on its only property CorrelationContext.

When this dependency is injected into a class, is it expected that the dependent type is able to modify the context via the interface?

My thinking is that dependents that need the correlation context shouldn't be able to change it too.

Can you clarify whether this is intended, or whether you'd accept a PR to change this behavior?

Cheers,
Matthew

@stevejgordon
Copy link
Owner

Thanks, @MatthewLymer. I'm trying to recall if I had a reason for this and I can't think of one. I think it would be reasonable to make it an internal setter. Since this would be a breaking change, it would need to go into a v4 release. I'd welcome a PR against the v4 branch if you have time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants