Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check FunctionalInterfaces and implementations #24

Open
7 of 17 tasks
mkalb opened this issue Mar 2, 2018 · 0 comments
Open
7 of 17 tasks

Check FunctionalInterfaces and implementations #24

mkalb opened this issue Mar 2, 2018 · 0 comments
Assignees
Milestone

Comments

@mkalb
Copy link
Member

mkalb commented Mar 2, 2018

  • Visibility of class variables (protected, package, private)
  • Functional method implementations (final or not final)
  • Getter methods for class variables (protected final)
  • final classes
  • default methods (more or less)
  • JavaDoc (Tags like see, author, since, ...)
  • Existing examples (stexfires-examples)
  • JUnit Tests for all methods and constructors
  • Generics: <? super T> and <? extends T>
  • Class names consistent
  • Parameter names consistent
  • Method names consistent
  • Many constructors or many static methods
  • Null handling (Record, Category, RecordId, ...)
  • Find usages and extensions (review, compare, ...)
  • Synchronize or thread-safe necessary (Supplier, long, double, Collections, Arrays, ...)
  • Method overload (generics, lambda friendly)
@mkalb mkalb self-assigned this Mar 2, 2018
@mkalb mkalb added this to the Milestone 0.1 milestone Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant