Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new quest: Is this smoothness still accurate? #5643

Closed
5 tasks done
danik292 opened this issue May 17, 2024 · 7 comments
Closed
5 tasks done

Add new quest: Is this smoothness still accurate? #5643

danik292 opened this issue May 17, 2024 · 7 comments

Comments

@danik292
Copy link

danik292 commented May 17, 2024

General

Affected tag(s) to be modified/added:
Question asked: Is this level of smoothness still accurate?

If yes leave the smoothness tag as it does and add information about the survey date.
If no let user choose new one and add information about survey date.

This check can be done every two years.

Checklist

Checklist for quest suggestions (see guidelines):

  • 🚧 To be added tag is established and has a useful purpose
  • 🤔 Any answer the user can give must have an equivalent tagging (Quest should not reappear to other users when solved by one)
  • 🐿️ Easily answerable by any pedestrian from the outside but a survey is necessary
  • 💤 Not an overwhelming percentage of quests have the same answer (No spam)
  • 🕓 Applies to a reasonable number of map data (Worth the effort)

Ideas for implementation

Element selection:

Metadata needed:

Proposed UI:

@rhhsm
Copy link

rhhsm commented May 17, 2024

I like this, but I like a smoothness overlay #5486 even more. An overlay would make an accuracy check unnecessary. @qugebert was going to work on it...

@mcliquid
Copy link
Contributor

The quest is asked every 4 years anyway, so why have an extra quest just for it?

See here for roads:


And here for paths:

@westnordost
Copy link
Member

Exactly, it is already implemented.

@westnordost westnordost closed this as not planned Won't fix, can't repro, duplicate, stale May 17, 2024
@danik292
Copy link
Author

@westnordost thank you for reply

@westnordost
Copy link
Member

westnordost commented May 17, 2024

Note however that it may not work as one might expect. It is true that it is asked every 4 years, but only if the road hasn't been modified in 4 years or a check_date:smoothness has been set and the set date is older than 4 years. Since roads are often updated due to other reasons and check_date:smoothness is set on roads very rarely, de-facto it will rarely be asked again.

The solution (IMO) would be to (instead of a quest) have an overlay, so users can check and correct the smoothness any time. But someone would need to implement this - #5486 - and I myself am busy with other things.

@qugebert
Copy link
Contributor

I like this, but I like a smoothness overlay #5486 even more. An overlay would make an accuracy check unnecessary. @qugebert was going to work on it...

Thanks for the reminder. I totally forgot about that. I'll have to see when I can find the time, but I want to look into it soon.

@qugebert
Copy link
Contributor

@danik292 I don't know if you are already familiar with SCEE (a StreetComplete fork), but there you can customize the filter settings. So, if you currently need more frequent intervals for resurveys, you could try that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants