Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not respond with a 500 error message if external APIs are down #943

Open
peetucket opened this issue Oct 16, 2018 · 2 comments
Open

Do not respond with a 500 error message if external APIs are down #943

peetucket opened this issue Oct 16, 2018 · 2 comments

Comments

@peetucket
Copy link
Member

If an API request comes in to search for publications by DOI, PMID or title, we may need to make a third party API call to Web of Science or PMID to service this call. If the 3rd party is down, we would respond with a 500 message to the caller of our API (which is the profiles system).

We should consider changing our response to a 200 with some other response (perhaps empty result set). This requires coordination with the Profiles team to decide how to better handle this scenario.

@peetucket peetucket added this to Backlog in SUL-Pub Mar 20, 2019
@jcoyne
Copy link
Contributor

jcoyne commented Apr 3, 2019

This sounds like a perfect situation for a 503 Service Unavailable

@peetucket
Copy link
Member Author

Yes, that would make more sense, though they would then have to do a better job trapping things on their end too to provide a better user experience. But that is out of our control, and a 503 is more accurate than 500.

@peetucket peetucket removed this from Backlog in SUL-Pub Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants