-
-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a planar screen as an optional assumption for handling off-disk helioprojective coordinates #7115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayshih
added
coordinates
Affects the coordinates submodule
No Backport
A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers)
labels
Jul 26, 2023
dstansby
reviewed
Oct 16, 2023
dstansby
added
the
Whats New?
Needs a section added to the current Whats New? page.
label
Oct 18, 2023
wtbarnes
force-pushed
the
assume_planar_screen
branch
from
March 28, 2024 21:16
c7e5dd5
to
b814eac
Compare
OK I've taken a crack at implementing the screens as separate classes and modifying the context manager and Some things to still left to do/decide
|
How this now works: import astropy.units as u
from astropy.coordinates import SkyCoord
from sunpy.coordinates import Helioprojective, SphericalScreen, PlanarScreen
frame = Helioprojective(observer='earth', obstime='2020-01-01')
coord = SkyCoord(Tx=[-1000, 300, 1000]*u.arcsec, Ty=[-1000, 300, 1000]*u.arcsec, frame=frame)
with SphericalScreen(coord.observer):
_ = coord.make_3d()
with PlanarScreen(coord.observer):
_ = coord.make_3d()
with PlanarScreen(coord.observer, distance_from_center=1*u.Rsun):
_ = coord.make_3d() |
wtbarnes
force-pushed
the
assume_planar_screen
branch
from
May 18, 2024 21:46
73e8120
to
fc5e542
Compare
wtbarnes
force-pushed
the
assume_planar_screen
branch
from
May 20, 2024 17:22
865870d
to
7615d28
Compare
nabobalis
approved these changes
May 21, 2024
wtbarnes
reviewed
May 29, 2024
nabobalis
force-pushed
the
assume_planar_screen
branch
from
June 12, 2024 21:18
6184116
to
1d33f72
Compare
wtbarnes
force-pushed
the
assume_planar_screen
branch
from
June 14, 2024 15:43
1d33f72
to
f8c04cd
Compare
wtbarnes
reviewed
Jul 1, 2024
wtbarnes
reviewed
Jul 1, 2024
wtbarnes
reviewed
Jul 1, 2024
wtbarnes
reviewed
Jul 1, 2024
nabobalis
force-pushed
the
assume_planar_screen
branch
from
July 3, 2024 20:38
f47e27b
to
4ebd796
Compare
nabobalis
approved these changes
Jul 3, 2024
nabobalis
added
the
Merge When CI Passes
Hit that merge button when it's all green!
label
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
coordinates
Affects the coordinates submodule
Merge When CI Passes
Hit that merge button when it's all green!
No Backport
A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers)
Whats New?
Needs a section added to the current Whats New? page.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanding beyond
assume_spherical_screen()
(see #4003), this PR adds a planar screen as an optional assumption for handling off-disk helioprojective coordinates.See also #6411